Make disabling the menu bar platform dependent. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When disabling the menu bar, on OS X there's still the (single) menu bar, but it will only have the default entries, not the ones installed by each major mode. Only disable the menu bar when not on 'darwin.
|
thanks for these! it sometimes takes me a little time to get around to pull requests, but I hope to in the next couple weeks. I really appreciate your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When disabling the menu bar, on OS X there's still the (single)
menu bar, but it will only have the default entries, not the ones
installed by each major mode. Only disable the menu bar when not on
'darwin.
This is a reopen of #16, which I'm closing because I opened it on master by mistake and want to push changes to my master for my own needs.