-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add reset flight plan on DB switch #7781
feat: add reset flight plan on DB switch #7781
Conversation
fix: flightplan icao search now robust with empty fp
...tml_ui/Pages/VCockpit/Instruments/Airliners/FlyByWire_A320_Neo/CDU/A320_Neo_CDU_IdentPage.js
Outdated
Show resolved
Hide resolved
...tml_ui/Pages/VCockpit/Instruments/Airliners/FlyByWire_A320_Neo/CDU/A320_Neo_CDU_IdentPage.js
Outdated
Show resolved
Hide resolved
...tml_ui/Pages/VCockpit/Instruments/Airliners/FlyByWire_A320_Neo/CDU/A320_Neo_CDU_IdentPage.js
Outdated
Show resolved
Hide resolved
...tml_ui/Pages/VCockpit/Instruments/Airliners/FlyByWire_A320_Neo/CDU/A320_Neo_CDU_IdentPage.js
Outdated
Show resolved
Hide resolved
...tml_ui/Pages/VCockpit/Instruments/Airliners/FlyByWire_A320_Neo/CDU/A320_Neo_CDU_IdentPage.js
Outdated
Show resolved
Hide resolved
...tml_ui/Pages/VCockpit/Instruments/Airliners/FlyByWire_A320_Neo/CDU/A320_Neo_CDU_IdentPage.js
Outdated
Show resolved
Hide resolved
...tml_ui/Pages/VCockpit/Instruments/Airliners/FlyByWire_A320_Neo/CDU/A320_Neo_CDU_IdentPage.js
Outdated
Show resolved
Hide resolved
...tml_ui/Pages/VCockpit/Instruments/Airliners/FlyByWire_A320_Neo/CDU/A320_Neo_CDU_IdentPage.js
Outdated
Show resolved
Hide resolved
fbw-a32nx/src/systems/fmgc/src/flightplanning/FlightPlanManager.ts
Outdated
Show resolved
Hide resolved
Might be worth looking into setting up vscode for code formatting. |
...tml_ui/Pages/VCockpit/Instruments/Airliners/FlyByWire_A320_Neo/CDU/A320_Neo_CDU_IdentPage.js
Outdated
Show resolved
Hide resolved
Co-authored-by: 2hwk <15316958+2hwk@users.noreply.github.com>
…Cockpit/Instruments/Airliners/FlyByWire_A320_Neo/CDU/A320_Neo_CDU_IdentPage.js Co-authored-by: Michael Corcoran <tracer@outlook.co.nz>
…Cockpit/Instruments/Airliners/FlyByWire_A320_Neo/CDU/A320_Neo_CDU_IdentPage.js Co-authored-by: Michael Corcoran <tracer@outlook.co.nz>
…Cockpit/Instruments/Airliners/FlyByWire_A320_Neo/CDU/A320_Neo_CDU_IdentPage.js Co-authored-by: Michael Corcoran <tracer@outlook.co.nz>
…Cockpit/Instruments/Airliners/FlyByWire_A320_Neo/CDU/A320_Neo_CDU_IdentPage.js Co-authored-by: Michael Corcoran <tracer@outlook.co.nz>
…Cockpit/Instruments/Airliners/FlyByWire_A320_Neo/CDU/A320_Neo_CDU_IdentPage.js Co-authored-by: Michael Corcoran <tracer@outlook.co.nz>
…Cockpit/Instruments/Airliners/FlyByWire_A320_Neo/CDU/A320_Neo_CDU_IdentPage.js Co-authored-by: Michael Corcoran <tracer@outlook.co.nz>
…Cockpit/Instruments/Airliners/FlyByWire_A320_Neo/CDU/A320_Neo_CDU_IdentPage.js Co-authored-by: Michael Corcoran <tracer@outlook.co.nz>
…Cockpit/Instruments/Airliners/FlyByWire_A320_Neo/CDU/A320_Neo_CDU_IdentPage.js Co-authored-by: Michael Corcoran <tracer@outlook.co.nz>
…Cockpit/Instruments/Airliners/FlyByWire_A320_Neo/CDU/A320_Neo_CDU_IdentPage.js Co-authored-by: Michael Corcoran <tracer@outlook.co.nz>
…ckwoe/a32nx-Maverickwoe into a32nx-DataBaseSwitchReset
…r.ts Reverted to original since async function issue will be resolved Co-authored-by: Michael Corcoran <tracer@outlook.co.nz>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Quality Assurance Tester Report Discord : mico#3145 Testing Process: -Setting an origin and destination in MCDU Second step Final step: Side effect: Negatives: Testing Results: Conclusions: |
Thanks for your verification @mico975 |
@Maverickwoe I've added a reference image to the ticket for the H4 confirmation message. Please make sure your implementation matches it (if it doesn't already). Thanks! |
Thanks for the image @beheh . Yes, I was aware of it and it is implemented as shown but disabled by config in my code for now. Note that I just committed a change to display the date in amber instead of red. I was shown an image that suggested it was red, not amber but will take yours as reference. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the testing instructions, I don't beleive a CHECK WEIGHT message should be generated. Perhaps there is something not quite right with it's logic.
...tml_ui/Pages/VCockpit/Instruments/Airliners/FlyByWire_A320_Neo/CDU/A320_Neo_CDU_IdentPage.js
Outdated
Show resolved
Hide resolved
...tml_ui/Pages/VCockpit/Instruments/Airliners/FlyByWire_A320_Neo/CDU/A320_Neo_CDU_IdentPage.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael Corcoran <tracer@outlook.co.nz>
Fixes #6216
Summary of Changes
Changed the Data/ "A/C" page on MCDU. You can now press on the secondary database. It will not switch to any other database as there is none available but it will
Added also an option to reflect future versions of FMC with confirmation before swapping database.
Did not implement anything related to FMC position reset, navigation display blank and speed prediction as navigation position has not yet been implemented.
Screenshots (if necessary)
Before:
After change :
References
Entirely relying on documentation that is listed in the issue #6216 (FMC manual)
Additional context
Discord username (if different from GitHub): Garoomf#4683
Testing instructions
Tests on video:
https://youtu.be/7NhjUAVqoa4 - on ground, complete test
https://youtu.be/ndm-00CtlyE - in flight, partial test
Test all combinations of these first steps:
-Setting an origin and destination in MCDU
-Adding additional nav points on the flight plan
-fly or on the ground
-add an additional waypoint in your database (or airport or navaid)
-add flight level, cost index and flight number
Second step
-go in Data/"A/C" page and press on the third button from top on the left.
-a scratch pad message shall appear "CHECK WEIGHT" only if in flight, it should not when on ground
-Verify there is no more any mention of stored data on the same page.
-Verify that the flight plan is blank on the FL PLN page
-Verify that the origin and destination are reset on INIT A, as well as Flight level, index and flight number.
-Verify on INIT B that Weight and fuel data are blanck
-Verify that the speed and heading switch to selected on AP if in flight
Final step:
-Set a new origin/destination in INIT A
-Verify that none of the data listed above reappears.
Side effect :
NOTE that these changes may affect also the STORED DATA erase on the same page.
Verifying that this other feature has not been affected is important too.
How to download the PR for QA
Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.