Merged
Conversation
Member
Author
These were obscured in the pre-release checks because some structural changes to the API docs hadn't been merged yet. Fix some to canonicalized urls Some are not technically errors since the redirect is in place, but the mismatch upsets the link checker's caching strategy so let's fix it. Signed-off-by: Kingdon Barrett <kingdon@weave.works>
65a87af to
fabe6e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were obscured in the pre-release checks because some structural changes to the API docs hadn't been merged yet.
We can merge these changes straight away, or wait a few minutes and I'll have more corrections based on the reporting output. I think that most (>50%) of the errors I'm seeing are actually properly redirected, so it's taking a bit of effort to see whether each bad link on the report is a bogon or a valid issue to follow up. Should be over in a few minutes though.