Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: new example using personal access tokens. #643

Merged
merged 1 commit into from
Apr 8, 2024
Merged

add: new example using personal access tokens. #643

merged 1 commit into from
Apr 8, 2024

Conversation

swade1987
Copy link
Member

@swade1987 swade1987 commented Apr 8, 2024

Description

This PR provides the following:

  • An example of bootstrapping a GitHub repository using a personal access token (PAT)
  • Updating the main README to include a contribution and community section

Motivation and Context

Fixes #633

How has this been tested?

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Documentation

  • I have updated the documentation (if required) with make docs

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritise this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rename the example dir to github-via-pat

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
examples/github-via-personal-access-token/main.tf Outdated Show resolved Hide resolved
examples/github-via-personal-access-token/main.tf Outdated Show resolved Hide resolved
@stefanprodan stefanprodan added area/docs Documentation related issues and pull requests area/testing Testing related issues and pull requests labels Apr 8, 2024
.github/workflows/tests.yaml Outdated Show resolved Hide resolved
examples/github-via-pat/providers.tf Outdated Show resolved Hide resolved
.github/workflows/tests.yaml Outdated Show resolved Hide resolved
Signed-off-by: Steven Wade <steven@stevenwade.co.uk>
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @swade1987 🏅

@stefanprodan stefanprodan merged commit 23a764f into fluxcd:main Apr 8, 2024
20 checks passed
@swade1987 swade1987 deleted the pat-example branch April 8, 2024 20:40
@fluxcd fluxcd locked as resolved and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/docs Documentation related issues and pull requests area/testing Testing related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add example for GitHub PAT bootstrap
2 participants