Skip to content

e2e: use podinfo chart for valuesfile tests #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hiddeco merged 2 commits into from
Oct 6, 2020
Merged

e2e: use podinfo chart for valuesfile tests #165

hiddeco merged 2 commits into from
Oct 6, 2020

Conversation

@hiddeco
Copy link
Member

@hiddeco hiddeco commented Oct 5, 2020 •
edited
Loading

This requires a new podinfo Helm chart release for the test to pass.

@hiddeco hiddeco added the area/ci CI related issues and pull requests label Oct 5, 2020
@hiddeco hiddeco mentioned this pull request Oct 5, 2020
Merged
@stefanprodan
Copy link
Member

stefanprodan commented Oct 6, 2020

Please use v5.x branch as master will go away at some point.

@hiddeco hiddeco force-pushed the e2e/fix-valuesfile-test branch from 4ab34b8 to 815e584 Compare October 6, 2020 07:27
@hiddeco hiddeco requested a review from stefanprodan October 6, 2020 07:28
@stefanprodan
Copy link
Member

stefanprodan commented Oct 6, 2020

You need to change the e2e:

          kubectl -n source-system wait helmchart/mariadb --for=condition=ready --timeout=5m
          kubectl -n source-system wait helmchart/mariadb-git --for=condition=ready --timeout=5m

@hiddeco hiddeco force-pushed the e2e/fix-valuesfile-test branch from 8a4935b to a0333c4 Compare October 6, 2020 07:45
stefanprodan
stefanprodan requested changes Oct 6, 2020
View reviewed changes
@hiddeco hiddeco force-pushed the e2e/fix-valuesfile-test branch from a0333c4 to 335a091 Compare October 6, 2020 08:37
@hiddeco hiddeco merged commit 20161ce into main Oct 6, 2020
@hiddeco hiddeco deleted the e2e/fix-valuesfile-test branch October 6, 2020 09:08
@stefanprodan stefanprodan mentioned this pull request Mar 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees

No one assigned

Labels

area/ci CI related issues and pull requests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hiddeco @stefanprodan