Skip to content

Set default branch to main #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stefanprodan merged 1 commit into from
Oct 5, 2020
Merged

Set default branch to main #163

stefanprodan merged 1 commit into from
Oct 5, 2020

Conversation

@stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Oct 5, 2020

@stefanprodan stefanprodan added the area/ci CI related issues and pull requests label Oct 5, 2020
@stefanprodan stefanprodan requested a review from hiddeco October 5, 2020 12:11
hiddeco
hiddeco approved these changes Oct 5, 2020
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When this is merged, and we have switched to main, we need to edit the links in the existing releases as they refer to the master branch.

@hiddeco
Copy link
Member

hiddeco commented Oct 5, 2020

You missed: https://github.com/fluxcd/source-controller/blob/019d8f12153555c62f333ac9b1e3245c86e18e09/docs/internal/release.md

@hiddeco
Copy link
Member

hiddeco commented Oct 5, 2020

and the badges in README.md: https://github.com/fluxcd/source-controller/blob/55c08e8aa9148f19e8becdd2b77c786ca8afe72f/README.md

@stefanprodan stefanprodan force-pushed the main-branch branch 2 times, most recently from 0cb424b to 408b7a6 Compare October 5, 2020 12:28
@stefanprodan
Set default branch to main
f81b479 
Signed-off-by: stefanprodan <stefan.prodan@gmail.com>
@hiddeco
Copy link
Member

hiddeco commented Oct 5, 2020

and also here, CHANGELOG.md: https://github.com/fluxcd/source-controller/blob/6966ac06aa105b94767926d3e9561a9dd4966a0e/CHANGELOG.md

@stefanprodan stefanprodan merged commit 856a218 into master Oct 5, 2020
@stefanprodan stefanprodan deleted the main-branch branch October 5, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hiddeco hiddeco hiddeco approved these changes

Assignees

No one assigned

Labels

area/ci CI related issues and pull requests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stefanprodan @hiddeco