Support Helm charts from Bucket sources #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
force-pushed
the
helmchart-bucket-source
branch
from
fc1fa28 to
b076f04
Compare
stefanprodan
approved these changes
Sep 18, 2020
Member
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
LGMT
We have to update the API docs, but that can come in a followup PR
scottrigby
reviewed
Sep 18, 2020
| Complete(r) | ||
| } | ||
|
|
||
| func (r *HelmChartReconciler) getSource(ctx context.Context, chart sourcev1.HelmChart) (sourcev1.Source, error) { |
Member
There was a problem hiding this comment.
Nice option, also nice function cleanup 👍
hiddeco
force-pushed
the
helmchart-bucket-source
branch
from
aad381e to
9c52d5b
Compare
hiddeco
added
area/helm
hiddeco
force-pushed
the
helmchart-bucket-source
branch
2 times, most recently
from
0c8baa5 to
406b305
Compare
hiddeco
changed the title
hiddeco
force-pushed
the
helmchart-bucket-source
branch
from
406b305 to
8cdb821
Compare
stefanprodan
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.