Skip to content

Fix unknown build error when reconciling HelmChart from an OCI Registry #894

Open
@souleb

Description

@souleb

HelmCharts reconciliation sometime result in unknown build error and Unknown reason with auth failure It happens when HelmChart build is attempted when the associated HelmRepository isn't ready because of the auth failure.
It then returns *conditions.TrueCondition(sourcev1.FetchFailedCondition, "Unknown", "unknown build error: failed to login to OCI registry").

Around source-controller/controllers/helmchart_controller.go we have a check for non-OCI charts to ensures that the HelmRepo has artifact before proceeding further. We can add a similar check for OCI where we make sure that the HelmRepo is ready before proceeding to build it. That way, we can avoid such Unknown errors and show better status conditions.

Metadata

Metadata

Assignees

Labels

area/helmHelm related issues and pull requestsarea/ociOCI related issues and pull requestsbugSomething isn't workinggood first issueGood for newcomers

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions