kustomize: Restore empty dir build #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
approved these changes
Jan 18, 2024
souleb
approved these changes
Jan 18, 2024
kustomize/kustomize_generator.go
Outdated
| @@ -26,7 +26,7 @@ import ( | |||
| "strings" | |||
| "sync" | |||
|
|
|||
| securefs "github.com/fluxcd/pkg/kustomize/filesys" | |||
| "github.com/hashicorp/go-multierror" | |||
There was a problem hiding this comment.
since we use go1.20 we could replace this with errors.Join()
stefanprodan
force-pushed
the
restore-emptydir-build
branch
from
7efbfc1 to
b551398
Compare
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
stefanprodan
force-pushed
the
restore-emptydir-build
branch
from
bd1f45b to
e4ca429
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kustomize v5.3 introduced a breaking change where it would error out with
kustomization.yaml is emptyif no resources are specified. This PR adds a placeholder to the generated file, to restore the previous behaviour and allow Flux to reconcile an empty dir.Fix: fluxcd/flux2#4509