[RFC-0011] - OTEL integration based on alerts #1149
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adri1197
force-pushed
the
otel
branch
2 times, most recently
from
6e2dbbd to
7a793ec
Compare
adri1197
changed the title
adri1197
force-pushed
the
otel
branch
4 times, most recently
from
261f89d to
95a19f7
Compare
stefanprodan
added
enhancement
Signed-off-by: Adrian Fernandez De La Torre <adri1197@gmail.com>
matheuscscp
reviewed
Aug 7, 2025
| @@ -215,6 +216,7 @@ func (s *EventServer) dispatchNotification(ctx context.Context, event *eventv1.E | |||
|
|
|||
| go func(n notifier.Interface, e eventv1.Event) { | |||
| pctx, cancel := context.WithTimeout(context.Background(), timeout) | |||
| pctx = context.WithValue(pctx, notifier.AlertMetadataContextKey{}, alert.ObjectMeta) | |||
There was a problem hiding this comment.
Please swap this line with defer cancel()
| apiv1beta3 "github.com/fluxcd/notification-controller/api/v1beta3" | ||
| ) | ||
|
|
||
| type AlertMetadataContextKey struct{} |
There was a problem hiding this comment.
Suggested change
| type AlertMetadataContextKey struct{} | |
| type alertMetadataContextKey struct{} |
There was a problem hiding this comment.
As discussed, please revert the changes in this file, as otel should be its own provider type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
GitRepository>Kustomization>HelmRepository>HelmReleaseOpen Questions
v1/traces(automatically managed by Otel GO SDK). In this way, it could allow that the notifications are sent to another endpoint, while the traces could be properly sent, as well (even though this endpoint convention must be met). Another alternative, could be to make it configurable by parsing the URL or some kind of convention?OtelTracer, even though it has not been populated as a new provider type. The rationale is to be able to rolling it out to the current providers that may support OpenTelemetry. At this moment, justgenerictype.Part of: #1097
Part of: fluxcd/flux2#5321