api: allow configuration of h unit for timeouts
#749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow waiting for `HelmRelease` resources with an exceptionally high timeout of `1h` or more. Related to: fluxcd/helm-controller#549 Signed-off-by: Hidde Beydals <hello@hidde.co>
|
@stefanprodan wondering if in a future patch it would be better to create separate values for some of the timeouts, as my assumption is that a validation and/or apply timeout should not take more than a couple minutes. Where as a health check might take longer. In extend to this, I am wondering if it would not be better to take note of the timestamp at which the health checks start, to then repetitively run health checks while re-queuing until they are healthy and/or it runs into the timeout compared to the timestamp. This would improve continuity. |
stefanprodan
approved these changes
Oct 21, 2022
|
Having a separate timeout for the health check makes sense, maybe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow waiting for
HelmReleaseresources with an exceptionally high timeout of1hor more.Related to: fluxcd/helm-controller#549