Revoke kubectl managed fields ownership #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
force-pushed
the
ssa-override-kubectl-manager
branch
10 times, most recently
from
48ddfab
to
1cc795f
Compare
kingdonb
pushed a commit
to kingdonb/bootstrap-repo
that referenced
this pull request
Jan 10, 2022
We are looking for notifications spam around the time that this upgrade goes into the cluster (I have just re-enabled slack notifications so that I will be able to tell one way or another)
stefanprodan
force-pushed
the
ssa-override-kubectl-manager
branch
3 times, most recently
from
7dcf93d
to
408a889
Compare
1 task
stefanprodan
force-pushed
the
ssa-override-kubectl-manager
branch
2 times, most recently
from
440702f
to
78bd051
Compare
|
This is a contribution of information to solve this issue On resource of kind Kustomization with v1beta2 we are switching from to The kustomize controller however does not seem to have the correct permissions due to managedFields to remove the Flux information. RC candidate setup: ► checking prerequisites pre RC candidate setup: ► checking prerequisites This is how a kustomization object looks before merging a switch from patchesStrategicMerge to patches look like After applying the RC and making the changes these are the two variants we have been seing on the kustomization We also had a successful run on the controller switching out the the two variants of patches by
Please let us know if we can be of any more assistance |
|
So we managed to work around the issue with stale So the way to proceed is to
|
24 tasks
stefanprodan
force-pushed
the
ssa-override-kubectl-manager
branch
6 times, most recently
from
0d8a732
to
ad94bd6
Compare
|
@ericjohansson89 with the latest version of this PR ( |
|
I can confirm, After testing several RCs this one looks like the winner 🎉 |
|
Edit: 🎉 user error, no problem found here I have not noticed any other strange behavior with any other Kustomization, and I have about 25 different Kustomizations running on this cluster, so while that's not conclusive, it looks like all the issues I was able to reproduce with prior versions, were fixed by this RC build. That includes:
If you're still experiencing difficulty removing any of the above, or any that I missed, after installing this Kustomize Controller RC, please let us know too. |
mvoitko
reviewed
Jan 24, 2022
|
I have performed more exhaustive tests against e611de4 with a matrix of Kubernetes minor versions in our support matrix and I believe this resolves the issue from all angles, 👍 LGTM |
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
stefanprodan
force-pushed
the
ssa-override-kubectl-manager
branch
from
e611de4
to
f353ba4
Compare
hiddeco
approved these changes
Jan 31, 2022
1 task
stefanprodan
added
the
area/server-side-apply
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enforces Flux ownership of Kubernetes objects' fields that were applied on the cluster outside of the declared desired state. In addition, metadata annotations and labels removed from Git and are now removed from the cluster.
In order to undo changes made with
kubectl apply -fandkubectl apply --server-side --force-conflicts, we have to replacekubectl-*managers with our own manager before the controller runs the server-side apply.In addition, this PR removes the kubectl last applied configuration annotation and Flux v1 & v2 deprecated metadata.
References:
Upstream bugs:
Test this PR using
ghcr.io/fluxcd/kustomize-controller:rc-e611de4e.To use the release candidate on your cluster, add the following image patch to
clusters/<cluster>/flux-system/kustomization.yaml:Big thanks to @somtochiama and @kingdonb for all the help validating this approach 🥇