Skip garbage collection of objects with owner references #411
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like #362 didn't do much, various Kubernetes controllers copy the metadata (labels and annotations) from their custom resources to generated objects. To fix this once and for all, kustomize-controller will skip pruning any object that has ownerReference.BlockOwnerDeletion=true. There is no reason why Flux should try to delete objects with
BlockOwnerDeletion
as Kubernetes GC should prune them.Fix: #415
Fix: #410
Test image
To test this PR please use the following image:
To upgrade kustomize-controller on an cluster bootstrapped with
flux
, add the followingimages
section to yourflux-system/kustomization.yaml
: