Repository navigation
Conversation
Reconcile only deletes a Kustomization's gotk_reconcile_duration_seconds series from the deferred metrics call, which never runs when Get returns NotFound. Objects removed without the controller's own finalize() completing (for example, a finalizer cleared externally after its remote target became unreachable) leak their series until the controller restarts. MetricsRecorder.DeleteDuration already takes a bare object reference, so call it directly on the NotFound path. No live object or new fluxcd/pkg API is needed. Includes a deterministic test driving two Reconcile calls against a fake client: the series survives without this fix and is removed with it. Signed-off-by: Wei-Chen Chen <zarcen@gmail.com> Signed-off-by: Wei-Chen Chen <weichen.chen@omniva.com> Assisted-by: claude-code/claude-sonnet-5
zarcen
marked this pull request as draft
October 12, 2026 23:54
zarcen
marked this pull request as draft
October 12, 2026 23:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1769
Drop a Kustomization's
gotk_reconcile_duration_secondsseries on the
NotFoundbranch ofReconcile, not only when a reconcileobserves the finalizer being removed.
Metrics.MetricsRecorder.DeleteDurationalready takes a bare object reference, so no new
fluxcd/pkgAPI is needed.Test plan:
go test ./internal/controller/ -run TestKustomizationReconciler_deleteMetricsOnNotFoundfails on
main, passes with this change.Related PRs