Disable status poller cache by default #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The status poller cache fills the all the available memory when reconciliation hundreds of resources in a single namespace. Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
stefanprodan
added
the
area/kstatus
hiddeco
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As observed in the benchmarks performed with https://github.com/stefanprodan/flux-benchmark, the status poller cache fills all the available memory when reconciliation hundreds of resources in-parallel in a single namespace. Disabling the cache by default makes the controller perform better at scale, but users can reenable the cache with
--feature-gates=DisableStatusPollerCache=false.Part of: fluxcd/flux2#4410