imagerepo: add .spec.insecure to ImageRepository
#472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryan9600
added
enhancement
14 tasks
aryan9600
force-pushed
the
imagerepo-insecure
branch
from
45e1dad
to
a6a16f3
Compare
darkowlzz
reviewed
Nov 23, 2023
|
Just a note about this change in relation to #368. When ImagePolicy starts connecting to the registry for fetching the digest, it'll also need to know about the insecure field associated with the ImageRepository image. What's in the spec may not match what's in the status for the current generation. So, both Image and Insecure fields will have to be recorded in the status for the observed generation of ImageRepository. |
Add a new boolean field `.spec.insecure` to the `ImageRepository` API. This enables connecting to insecure registries hosted at an HTTP endpoint. Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
aryan9600
force-pushed
the
imagerepo-insecure
branch
from
a6a16f3
to
15a1b09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new boolean field
.spec.insecureto theImageRepositoryAPI. This enables connecting to insecure registries hosted at an HTTP endpoint.Fixes #325
Related to https://github.com/fluxcd/flux2/tree/main/rfcs/0004-insecure-http