This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Allow for deploying Tiller as a sidecar. #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a side note, I think this may also be of use to whoever justs wants to try |
bmcustodio
force-pushed
the
master
branch
2 times, most recently
from
6c5338c
to
df47c23
Compare
stefanprodan
suggested changes
Oct 21, 2019
|
Thank you @stefanprodan, accepted both changes! |
stefanprodan
suggested changes
Oct 21, 2019
|
@stefanprodan done! |
stefanprodan
suggested changes
Oct 22, 2019
chart/helm-operator/Chart.yaml
Outdated
| @@ -1,6 +1,6 @@ | |||
| apiVersion: v1 | |||
| appVersion: "1.0.0-rc3" | |||
| version: 0.2.1 | |||
| version: 0.3.0 | |||
There was a problem hiding this comment.
Please undo this change, the version will be bumped when we do a Helm-op release
Signed-off-by: Bruno Miguel Custódio <brunomcustodio@gmail.com>
|
If you release this, I might give you a kiss when I meet you next. |
dmccaffery
added a commit
to deavon-and-tiffany/helm-charts
that referenced
this pull request
Apr 20, 2020
NOTE: In order for flux and the helm-operator to work successfully, an instance of tiller must be deployed into the cluster. This is a security vulnerability in that the tiller account executes with a highly privileged role. This should be removed once fluxcd/helm-operator#79 has been released. The current version of the helm-operator (1.0.0-rc3) does not include this PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I propose adding support in the Helm chart for deploying Tiller as a sidecar (restricted to
localhost). This is inspired by a comment by @justinbarrick, and I believe that, although possibly being an advanced scenario, would be of use for some people ( like me 🙂 ). Tiller is eventually going away, but I believe this may be a useful addition while #8 isn't finished. I've kept this new feature undocumented because it's probably a good idea to "restrict" access to it to whoever finds themselves in need of fiddling withvalues.yaml( and also because I am not quite sure this will get accepted as a feature 🙂 ).