Upgrade controller-runtime to v0.23.1

[matheuscscp]

Fixes: #1394

This PR is also fixing CRD upgrades with the CreateReplace policy, whose test that runs only in the main branch is failing:

https://github.com/fluxcd/helm-controller/actions/runs/21357699633

[matheuscscp]

There are two issues with CRDs:

1. First issue is trivial, fixed in 0062015
2. Second issue: Helm's kstatus implementation is getting stuck waiting after the CreateReplace

Still investigating 2. (and wondering if we can hard-code the legacy waiter for CRDs...)

[matheuscscp]

Still investigating 2. (and wondering if we can hard-code the legacy waiter for CRDs...)

Simple: kstatus has no special handling for CRDs and CRDs do not have the Ready condition :)

This is Helm's legacy waiting logic for CRDs:

func (c *ReadyChecker) crdReady(crd apiextv1.CustomResourceDefinition) bool {
	for _, cond := range crd.Status.Conditions {
		switch cond.Type {
		case apiextv1.Established:
			if cond.Status == apiextv1.ConditionTrue {
				return true
			}
		case apiextv1.NamesAccepted:
			if cond.Status == apiextv1.ConditionFalse {
				// This indicates a naming conflict, but it's probably not the
				// job of this function to fail because of that. Instead,
				// we treat it as a success, since the process should be able to
				// continue.
				return true
			}
		default:
			// intentionally left empty
		}
	}
	return false
}

[matheuscscp]

Actually, kstatus does have logic for CRDs:

func crdConditions(u *unstructured.Unstructured) (*Result, error) {
	obj := u.UnstructuredContent()

	objc, err := GetObjectWithConditions(obj)
	if err != nil {
		return nil, err
	}

	for _, c := range objc.Status.Conditions {
		if c.Type == "NamesAccepted" && c.Status == corev1.ConditionFalse {
			return newFailedStatus(c.Reason, c.Message), nil
		}
		if c.Type == "Established" {
			if c.Status == corev1.ConditionFalse && c.Reason != "Installing" {
				return newFailedStatus(c.Reason, c.Message), nil
			}
			if c.Status == corev1.ConditionTrue {
				return &Result{
					Status:     CurrentStatus,
					Message:    "CRD is established",
					Conditions: []Condition{},
				}, nil
			}
		}
	}
	return newInProgressStatus("Installing", "Install in progress"), nil
}

[matheuscscp]

kstatus is correctly waiting for the CRDs, the issue is actually waiting for the CRs, see: helm/helm#31768

[stefanprodan]

LGTM