Skip to content

Fix watch index conflict between HelmChart and OCIRepository kinds #1266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2025
Merged

Fix watch index conflict between HelmChart and OCIRepository kinds #1266

merged 1 commit into from
Jul 19, 2025

Conversation

matheuscscp
Copy link
Member

There could be an OCIRepository and a HelmChart with the same {namespace}/{name}, so the watch index should make a distinction using the kind.

Also fixing a typo requestsForOCIRrepositoryChange -> requestsForOCIRepositoryChange.

@matheuscscp
Fix watch index conflict between HelmChart and OCIRepository kinds
7780c45 
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
@matheuscscp matheuscscp added the bug Something isn't working label Jul 19, 2025
stefanprodan
stefanprodan approved these changes Jul 19, 2025
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matheuscscp matheuscscp merged commit 5a28a76 into main Jul 19, 2025
7 checks passed
@matheuscscp matheuscscp deleted the fix-source-index branch July 19, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matheuscscp @stefanprodan