Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table panel to list suspended objects #11

Merged

Conversation

knutgoetz
Copy link
Contributor

Added a table panel to list suspended objects to the Flux Cluster Stats dashboard. I rearranged the other tables a bit, not sure if this is to everyone's liking.

Panel

Fixes #10

Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this panel. I tried it and it works as advertised. Overall, looks good to me.
Left a small suggestion that can be addressed before we merge this.

monitoring/configs/dashboards/cluster.json Outdated Show resolved Hide resolved
monitoring/configs/dashboards/cluster.json Show resolved Hide resolved
@stefanprodan stefanprodan added the enhancement New feature or request label Oct 27, 2023
Signed-off-by: Knut Götz <knutgoetz@gmail.com>
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks.

@darkowlzz darkowlzz merged commit eb3bb8d into fluxcd:main Oct 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table panel for displaying suspended objects
3 participants