Fix hardcoded docker config file (#1)

Add parameter and default value in place of hard-coded /dockercfg/config.json
fluxcd · Apr 11, 2019 · fde16bc · fde16bc
1 parent 0362217
commit fde16bc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/chart/flux/templates/deployment.yaml b/chart/flux/templates/deployment.yaml
@@ -163,7 +163,7 @@ spec:
           - --registry-require=ecr
           {{- end }}
           {{- if .Values.registry.dockercfg.enabled }}
-          - --docker-config=/dockercfg/config.json
+          - --docker-config={{ .Values.registry.dockercfg.configFileName }}
           {{- end }}
           {{- if .Values.token }}
           - --connect=wss://cloud.weave.works/api/flux

diff --git a/chart/flux/values.yaml b/chart/flux/values.yaml
@@ -162,6 +162,7 @@ registry:
   dockercfg:
     enabled: false
     secretName: ""
+    configFileName: /dockercfg/config.json
 memcached:
   repository: memcached
   tag: 1.4.25