Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry canary initialization on conflict #586

Merged
merged 2 commits into from
May 14, 2020
Merged

Retry canary initialization on conflict #586

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6cfa432
Retry canary initialization on conflict
stefanprodan May 14, 2020
e7f2d22
Fix svc update conflict
stefanprodan May 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix svc update conflict
  • Loading branch information
@stefanprodan
stefanprodan committed May 14, 2020
commit e7f2d2250591aff33b0a800ca8dd0a631400ba47
1 change: 0 additions & 1 deletion pkg/router/kubernetes_default.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,6 @@ func (c *KubernetesDefaultRouter) reconcileService(canary *flaggerv1.Canary, nam
if portsDiff != "" || selectorsDiff != "" {
svcClone.Spec.Ports = svcSpec.Ports
svcClone.Spec.Selector = svcSpec.Selector
_, err = c.kubeClient.CoreV1().Services(canary.Namespace).Update(context.TODO(), svcClone, metav1.UpdateOptions{})
updateService = true
}

Expand Down