Add validation for primaryScalerReplicas counts #1702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aufarg
force-pushed
the
add-autoscaler-ref-validation
branch
2 times, most recently
from
82e9c4c
to
35ec90a
Compare
Signed-off-by: Aufar Gilbran <aufargilbran@gmail.com>
aufarg
force-pushed
the
add-autoscaler-ref-validation
branch
from
35ec90a
to
b719427
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Canary object right now accepts values lower than one (
1) forprimaryScalerReplicascounts. This results in Flagger keep trying to update primary HPA replica count, but failing. The validation is added to prevent the invalid object definition to be applied in the first place.