Skip to content

Canary pods not getting terminated after canary promotion when used with Keda #1798

Open
@cmodi-cogito

Description

@cmodi-cogito

Describe the bug

I have implemented canary deployment with Keda as per this doc - https://docs.flagger.app/tutorials/keda-scaledobject

It works fine except it's not removing canary pods after promotion.

As per doc, It should remove this annotation autoscaling.keda.sh/paused-replicas":"0" from ScaledObject during canary analysis so canary pods can scale up and it should add it back after promotion which would terminate canary pods but it does not add this annotation back to ScaledObject.

So not sure why and how this annotation gets deleted and why it's not added back after canary promotion.

NOTE: It works fine If I use native HPA for autoscaling instead of Keda scaling

To Reproduce

I have followed exactly same steps mentioned in doc - https://docs.flagger.app/tutorials/keda-scaledobject

Also I tried to add 2 annotations dummy: "yes" and autoscaling.keda.sh/paused-replicas":"0" manually on Keda ScaledObject resource but only autoscaling.keda.sh/paused-replicas":"0" annotation got deleted instantly triggering pod termination and as this annotation got deleted, canary pods came back again.

Expected behavior

It should scale down canary pods to 0 after canary promotion.

Additional context

  • Flagger version: 1.41.0
  • Keda version: 2.10.1
  • Kubernetes version: 1.30
  • Service Mesh provider: Istio
  • Ingress provider: Kong

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions