-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Flux batch job HOWTO section #57
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Just added a couple inline notes. I thought it might be good to clarify what a "batch job" means in Flux (as compared to a submitted job).
Maybe what we need is more of a glossary page, where we delineate these terms, and to which we can add a reference from these HOWTOs.
From the initial feedback from Xiaohua, there are a few things that I'd like to add to this:
|
This looks great, Dong. My only comments are things you've already pointed out: I think it would be good to point out that there are two ways, blocking and nonblocking, to submit batch jobs and regular jobs: alloc, batch, run, and submit. You might also want to provide a full example of using Flux on Slurm with outer_script.sh:
inner_script.sh:
And you submit this to Slurm with |
83eda2d
to
e049524
Compare
OK. I have addressed all of the reviewers' (great) comments and incorporated the finings from working with users. I squashed all the interim commits. From my perspective, this is good to go in. |
Add doc on how to submit your batch scripts with some examples. Use single-user Flux examples with a caveat that same commands and techniques will also work at the system level.
Ok. I resolved the conflicts and forced a push. It will be good if we can merge this sooner rather than later. We already have some users needing this doc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Add doc on how to submit your batch scripts with
some examples.
Use single-user Flux examples with a caveat that
same commands and techniques will also work at the system level.