Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tutorials: add flux mini run tutorial/example #202

Merged
merged 7 commits into from
Feb 13, 2023

Conversation

chu11
Copy link
Member

@chu11 chu11 commented Feb 13, 2023

originally in #193, we intended to be in the flux mini submit tutorial but I guess we forgot about it. I didn't think it was worthwhile to separate it out to a new tutorial b/c its so small and highly related to flux mini submit. So I put it in there.

Lots of mini cleanups along the way too.

@chu11 chu11 mentioned this pull request Feb 13, 2023
16 tasks
Copy link
Member

@cmoussa1 cmoussa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chu11
Copy link
Member Author

chu11 commented Feb 13, 2023

@cmoussa1 thanks for the review. I jut realized that some of the cleanups I did in #200 conflict with this PR. Since #200 is still being worked on, I just went ahead and stole those cleanups and put them in here so they wouldn't conflict with newer PRs I'm going to start. Could you take a quick skim again and make sure these new cleanups are ok too.

Copy link
Member

@cmoussa1 cmoussa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new cleanups LGTM too. Thanks @chu11!

@chu11 chu11 added the merge-when-passing mark PR for auto-merging by mergify.io bot label Feb 13, 2023
Al Chu11 added 7 commits February 13, 2023 18:47
Problem: "flux mini submit" is probably the most basic command to learn, but
is listed second.

Lets list it first.  Also remove the hyphens in the command listing.
Problem: When flux is used alone in a statement, i.e. "Flux instance",
Flux should be capitalized.

Capitalize Flux.
Problem: Flux commands, i.e. flux start, should be marked up.

Use double backticks around "flux start" in several locations.
Problem: There is some trailing whitespace in the flux mini submit
tutorial.

Remove it.
Problem: The code blocks in flux-mini-submit were syntax
highlighted to 'sh', but they should just be 'console' output.

Update all code blocks to be 'console' colorized.
Problem: The convention is to use lowercase "jobid" to reference
jobids.

Change jobID to jobid in flux-mini-submit tutorial.
Problem: The flux mini submit tutorial was also supposed to have
a flux mini run example, but was forgotten.

Add flux mini run tutorial to flux mini submit.
@mergify
Copy link
Contributor

mergify bot commented Feb 13, 2023

⚠️ This pull request got rebased on behalf of a random user of the organization.
This behavior will change on the 1st February 2023, Mergify will pick the author of the pull request instead.

To get the future behavior now, you can configure bot_account options (e.g.: bot_account: { author } or update_bot_account: { author }.

Or you can create a dedicated github account for squash and rebase operations, and use it in different bot_account options.

@mergify mergify bot merged commit ec9ae29 into flux-framework:master Feb 13, 2023
@chu11 chu11 deleted the flux_mini_run branch February 13, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-when-passing mark PR for auto-merging by mergify.io bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants