-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tutorials: add flux mini run tutorial/example #202
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@cmoussa1 thanks for the review. I jut realized that some of the cleanups I did in #200 conflict with this PR. Since #200 is still being worked on, I just went ahead and stole those cleanups and put them in here so they wouldn't conflict with newer PRs I'm going to start. Could you take a quick skim again and make sure these new cleanups are ok too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new cleanups LGTM too. Thanks @chu11!
Problem: "flux mini submit" is probably the most basic command to learn, but is listed second. Lets list it first. Also remove the hyphens in the command listing.
Problem: When flux is used alone in a statement, i.e. "Flux instance", Flux should be capitalized. Capitalize Flux.
Problem: Flux commands, i.e. flux start, should be marked up. Use double backticks around "flux start" in several locations.
Problem: There is some trailing whitespace in the flux mini submit tutorial. Remove it.
Problem: The code blocks in flux-mini-submit were syntax highlighted to 'sh', but they should just be 'console' output. Update all code blocks to be 'console' colorized.
Problem: The convention is to use lowercase "jobid" to reference jobids. Change jobID to jobid in flux-mini-submit tutorial.
Problem: The flux mini submit tutorial was also supposed to have a flux mini run example, but was forgotten. Add flux mini run tutorial to flux mini submit.
To get the future behavior now, you can configure Or you can create a dedicated github account for squash and rebase operations, and use it in different |
cba26a6
to
c361e3c
Compare
originally in #193, we intended to be in the
flux mini submit
tutorial but I guess we forgot about it. I didn't think it was worthwhile to separate it out to a new tutorial b/c its so small and highly related toflux mini submit
. So I put it in there.Lots of mini cleanups along the way too.