Makes Core into Core and Client and Exposes Client API to Users #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilumsden
force-pushed
the
exported_core
branch
2 times, most recently
from
d2c8a4c to
bc4735f
Compare
ilumsden
force-pushed
the
exported_core
branch
from
8206e82 to
57991dd
Compare
ilumsden
changed the title
|
I tested this using A4X, and it works as expected |
|
Yes. This PR is ready for review and merge. |
This was referenced Dec 13, 2024
ilumsden
force-pushed
the
exported_core
branch
from
8622168 to
360b836
Compare
ilumsden
force-pushed
the
exported_core
branch
from
1a7dcc0 to
f971405
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on feedback from #118. If we like it, it can supersede and replace #118.
This PR moves headers around and modifies the CMake to make DYAD's core and ctx libraries available to users. It also splits
dyad_core.handdyad_structures.hinto multiple headers (an external header and an internal one) so that excess function definitions are not exposed to users. It also creates a newdyad/core/dyad.hheader anddyad_clientCMake target to refer to both libraries at once.