test(share_plus): Integration test #1033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miquelbeltran
requested changes
Aug 24, 2022
packages/share_plus/share_plus/example/integration_test/share_plus_test.dart
Outdated
Show resolved
Hide resolved
| expect(Share.share('message', subject: 'title'), completes); | ||
| }); | ||
|
|
||
| testWidgets('Tests if the expected non-null result is returned', |
Member
There was a problem hiding this comment.
I mean, it is an improvement :) but could you add a reference to the method name shareWithResult?
e.g. "Can launch shareWithResult and result is not null."
Member
|
I think you misunderstood me. The test descriptions that you set are not valid and must be changed. Please set the following test descriptions:
|
Contributor
Author
|
Sorry, I thought it was to improve my vocabulary. But it is true that the naming you gave would be a bit more exact. Learned. So let's see if the latest submission meets the requirements. |
miquelbeltran
approved these changes
Aug 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now our integration test supports the Android platform.
Write an integration test of the share_plus plugin supporting the Android Platform.
Related Issues
This is a GSoC task, so there are no associated issues for now.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process.
pubspec.yamlandCHANGELOG.md.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?