We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thank you for adding the inclusive flag on popScopeUntil. I feel the assert needs to be updated with the new flag though. https://github.com/fluttercommunity/get_it/blob/master/lib/get_it_impl.dart#L795
This should be valid but fails due to the current assert. Since it's popping everything except the baseScope.
await GetIt.I.popScopesTill('baseScope', inclusive: false);
Current:
assert(scopeName != _baseScopeName, "You can't pop the base scope");
Suggested
assert(inclusive && scopeName != _baseScopeName, "You can't pop the base scope");
The text was updated successfully, but these errors were encountered:
Sorry for the late response, I had to take a longer break due to health issues. Thanks for this catch, will be fixed in the next release
Sorry, something went wrong.
fix for #299
0508f26
fixed in V7.6.0
Thank you. Good to see you back!
No branches or pull requests
Thank you for adding the inclusive flag on popScopeUntil. I feel the assert needs to be updated with the new flag though.
https://github.com/fluttercommunity/get_it/blob/master/lib/get_it_impl.dart#L795
This should be valid but fails due to the current assert. Since it's popping everything except the baseScope.
Current:
Suggested
The text was updated successfully, but these errors were encountered: