-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fixed allowMute being ignored on Desktop #896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed allowMute being ignored on Desktop #896
Conversation
@mpoimer thank you for your pending contribution. Please re-sync your branch with |
7235e68
to
ade5079
Compare
@diegotori done |
@@ -31,8 +31,7 @@ class MaterialDesktopControls extends StatefulWidget { | |||
} | |||
} | |||
|
|||
class _MaterialDesktopControlsState extends State<MaterialDesktopControls> | |||
with SingleTickerProviderStateMixin { | |||
class _MaterialDesktopControlsState extends State<MaterialDesktopControls> with SingleTickerProviderStateMixin { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may want to revert the formatting changes, so that the CI doesn't complain when it attempts to format it.
That and it'll make it easier to see the actual change made.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's still some formatting issues that CI is complaining about.
To fix those, downgrade to 3.27, then run dart formal in the codebase. Thanks in advance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #896 +/- ##
==========================================
+ Coverage 44.91% 44.95% +0.03%
==========================================
Files 22 22
Lines 1545 1546 +1
==========================================
+ Hits 694 695 +1
Misses 851 851 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
No description provided.