Fixed allowMute being ignored on Desktop #896
Conversation
|
@mpoimer thank you for your pending contribution. Please re-sync your branch with |
mpoimer
force-pushed
the
bugfix/mute-on-desktop
branch
from
7235e68 to
ade5079
Compare
|
@diegotori done |
|
|
||
| class _MaterialDesktopControlsState extends State<MaterialDesktopControls> | ||
| with SingleTickerProviderStateMixin { | ||
| class _MaterialDesktopControlsState extends State<MaterialDesktopControls> with SingleTickerProviderStateMixin { |
There was a problem hiding this comment.
You may want to revert the formatting changes, so that the CI doesn't complain when it attempts to format it.
That and it'll make it easier to see the actual change made.
There was a problem hiding this comment.
Looks like there's still some formatting issues that CI is complaining about.
To fix those, downgrade to 3.27, then run dart formal in the codebase. Thanks in advance.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #896 +/- ##
==========================================
+ Coverage 44.91% 44.95% +0.03%
==========================================
Files 22 22
Lines 1545 1546 +1
==========================================
+ Hits 694 695 +1
Misses 851 851 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* commit '0a390f93ff98010cbc97ae7017dd064045221448': chewie, version 1.11.1. Addresses Issues fluttercommunity#875, fluttercommunity#896, and fluttercommunity#910. Fix example on web Add background tap to pause formatted with dart 3.27 reverted formatting Fixed allowMute being ignored on Desktop # Conflicts: # lib/src/chewie_player.dart
2 participants
No description provided.