Skip to content

Fixed allowMute being ignored on Desktop #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 1, 2025

Conversation

mpoimer
Copy link
Contributor

@mpoimer mpoimer commented Feb 27, 2025

No description provided.

@diegotori
Copy link
Collaborator

@mpoimer thank you for your pending contribution. Please re-sync your branch with master's latest changes. Thanks.

@mpoimer mpoimer force-pushed the bugfix/mute-on-desktop branch from 7235e68 to ade5079 Compare March 13, 2025 17:16
@mpoimer
Copy link
Contributor Author

mpoimer commented Mar 13, 2025

@diegotori done

@@ -31,8 +31,7 @@ class MaterialDesktopControls extends StatefulWidget {
}
}

class _MaterialDesktopControlsState extends State<MaterialDesktopControls>
with SingleTickerProviderStateMixin {
class _MaterialDesktopControlsState extends State<MaterialDesktopControls> with SingleTickerProviderStateMixin {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to revert the formatting changes, so that the CI doesn't complain when it attempts to format it.

That and it'll make it easier to see the actual change made.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's still some formatting issues that CI is complaining about.

To fix those, downgrade to 3.27, then run dart formal in the codebase. Thanks in advance.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@mpoimer mpoimer requested a review from diegotori March 27, 2025 18:24
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.95%. Comparing base (d172b64) to head (2aca16e).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #896      +/-   ##
==========================================
+ Coverage   44.91%   44.95%   +0.03%     
==========================================
  Files          22       22              
  Lines        1545     1546       +1     
==========================================
+ Hits          694      695       +1     
  Misses        851      851              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@diegotori diegotori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@diegotori diegotori merged commit cafa5cf into fluttercommunity:master Apr 1, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants