Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bufferingBuilder #838

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Add bufferingBuilder #838

merged 2 commits into from
Sep 3, 2024

Conversation

daniellampl
Copy link
Contributor

@daniellampl daniellampl commented Jun 5, 2024

Add long requested (#80) bufferingBuilder for customizing the widget built while chewie buffers the video.

@diegotori
Copy link
Collaborator

@daniellampl Thanks for your contribution.

Please re-sync your PR with master's latest changes. Thanks.

@daniellampl
Copy link
Contributor Author

Done ✅

@Ahmadre
Copy link
Collaborator

Ahmadre commented Sep 3, 2024

Done ✅

Thanks! I try to test this tomorrow after work. Can't promise, but this should be introduced into chewie.

Copy link
Collaborator

@diegotori diegotori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Ahmadre
Copy link
Collaborator

Ahmadre commented Sep 3, 2024

LGTM's too :3 works like a charm. Good job!

@Ahmadre Ahmadre merged commit b4c3a0c into fluttercommunity:master Sep 3, 2024
3 checks passed
diegotori added a commit that referenced this pull request Sep 3, 2024
@diegotori
Copy link
Collaborator

Published in version 1.8.4. Congrats @daniellampl.

lg8294 added a commit to lg8294/chewie that referenced this pull request Sep 13, 2024
…ustom-lg

* commit '75085dccc419afa0329fc20e007c9299b38663ed':
  chewie, version 1.8.4. Addresses Issue fluttercommunity#838.
  Add bufferingBuilder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants