Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Seek buttons for Android #703

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

GyanendroKh
Copy link
Contributor

Adding Forward and Backward seek buttons for Android.
Fixes #615

@diegotori
Copy link
Collaborator

If you can accomplish this for CupertinoControls, then I would accept this PR.

@brianegan any thoughts on this proposed change, since that would be nice if users were able to seek.

@GyanendroKh
Copy link
Contributor Author

If you can accomplish this for CupertinoControls, then I would accept this PR.

@brianegan any thoughts on this proposed change, since that would be nice if users were able to seek.

CupertinoControls already have seek buttons on the bottom bar.

https://github.com/fluttercommunity/chewie/blob/master/lib/src/cupertino/cupertino_controls.dart#L277-L279

Isn't this the one that you are referring to

lib/src/center_seek_button.dart Outdated Show resolved Hide resolved
lib/src/center_seek_button.dart Outdated Show resolved Hide resolved
@andes2912
Copy link

andes2912 commented May 17, 2024

Please merge this PR, because Android need this feature

@Ahmadre
Copy link
Collaborator

Ahmadre commented Sep 3, 2024

Please merge this PR, because Android need this feature

We can't merge changes without investigating and the changes are done which @diegotori requested. Please update your PR accordingly and we will test this :)

@diegotori
Copy link
Collaborator

@Ahmadre if you have capacity, please review his changes by running them locally.

I wanna say that there were exceptions thrown due to the current library calling setState while in the middle of one.

Thanks.

@Ahmadre
Copy link
Collaborator

Ahmadre commented Sep 10, 2024

LGTM @diegotori

Your change requests seems to be implemented. We can merge this if you want.

Copy link
Collaborator

@diegotori diegotori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@diegotori diegotori merged commit 34d7b5f into fluttercommunity:master Sep 10, 2024
@diegotori
Copy link
Collaborator

@Ahmadre can you please submit a follow-up PR that fixes lint issues related to this one? Thanks.

@diegotori
Copy link
Collaborator

@Ahmadre nevermind, managed to nip it when publishing 1.8.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature-request] For android forward and backward controls like iOS
4 participants