Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

增加alignment字段控制视频排列 #222

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zhangweiwei0326
Copy link

由于placeholder 能够居左,视频默认是center 此处改成Container 便于自定义

@Ahmadre
Copy link
Collaborator

Ahmadre commented Nov 9, 2020

由于placeholder 能够居左,视频默认是center 此处改成Container 便于自定义

Hello @zhangweiwei0326 ,

we would appreciate it, if you can talk with us in English :) otherwise we'll try to translate, but it could be misunderstood ^^. Anyways: For what use cases do you need alignment? Could you demonstrate it via a GIF, Code or explain it?

Best regards
Rebar

@syssam
Copy link

syssam commented Nov 14, 2020

@Ahmadre

The user can set placeholder as alignment left, but the video container must be center.
That's why he wants to add alignment.
However, I don't understand why placeholder use alignment left.
normally, the placeholder should be a video cover.

@Ahmadre
Copy link
Collaborator

Ahmadre commented Nov 14, 2020

@Ahmadre

The user can set placeholder as alignment left, but the video container must be center.

That's why he wants to add alignment.

However, I don't understand why placeholder use alignment left.

normally, the placeholder should be a video cover.

Actually this hasn't to do with chewie but with video_player. But that issue what you're describing doesn't exist on video player. I always see the cover. And if you don't try to await initialize(); before you show any view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants