Skip to content

SubHeader #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 5, 2020
Merged

SubHeader #29

merged 12 commits into from
Jun 5, 2020

Conversation

daadu
Copy link
Member

@daadu daadu commented May 30, 2020

Closes #26

@daadu daadu requested a review from WieFel May 30, 2020 20:18
@daadu
Copy link
Member Author

daadu commented May 30, 2020

@WieFel Can you please document BackdropSubHeader. I tried but failed to describe it properly.

daadu
daadu commented May 30, 2020
View reviewed changes
@daadu daadu assigned daadu and WieFel Jun 1, 2020
@daadu daadu added this to the v1.0 milestone Jun 1, 2020
@felixwortmann
Copy link
Contributor

felixwortmann commented Jun 1, 2020 •
edited
Loading

I think it is good. I have two improvements though:

  1. There should be a bool to not show the subHeader when the FrontPanel is visible
  2. There should be a bool to hide the FloatingActionButton when the BackPanel is visible (since it overlays sometimes)

@felixwortmann
Copy link
Contributor

felixwortmann commented Jun 1, 2020 •
edited
Loading

I just implemented both of my proposed changes here

@daadu can you take a look and tell me what you think?

@daadu
Copy link
Member Author

daadu commented Jun 3, 2020

@felixwortmann We are planning to give callbacks in #30 so that this changes could be handled by user itself.

@daadu
Copy link
Member Author

daadu commented Jun 3, 2020 •
edited
Loading

@WieFel Is review complete for this PR?

@felixwortmann
Copy link
Contributor

felixwortmann commented Jun 3, 2020 •
edited
Loading

@daadu Seems good, that might be an even better way to handle this.

@WieFel
Copy link
Collaborator

WieFel commented Jun 3, 2020 •
edited
Loading

@daadu sorry, I missed to press the "submit review" button :D

WieFel
WieFel requested changes Jun 4, 2020
View reviewed changes
@daadu daadu requested a review from WieFel June 4, 2020 12:36
@daadu
- [BackdropSubHeader] padding defaults to `EdgeInsets.symmetric(verti…
1bab921 
…cal: 12.0, horizontal: 16.0)`

- [BackdropSubHeader] set `endIndent` to 16.0 for default `divider`
@daadu
Copy link
Member Author

daadu commented Jun 5, 2020

LGTM.

What about you ? @WieFel @felixwortmann

@felixwortmann
Copy link
Contributor

Same

@daadu daadu merged commit 9c62adb into master Jun 5, 2020
@daadu daadu deleted the feature/#26-subheader branch June 5, 2020 10:00
@daadu
Copy link
Member Author

daadu commented Jun 5, 2020

This feature has landed in v0.3.4 in pub.dev.

@daadu daadu restored the feature/#26-subheader branch June 5, 2020 10:08
@daadu daadu deleted the feature/#26-subheader branch June 5, 2020 10:30
@renovate renovate bot mentioned this pull request May 1, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WieFel WieFel WieFel approved these changes

@felixwortmann felixwortmann felixwortmann approved these changes

Assignees

@daadu daadu

@WieFel WieFel

Labels
None yet
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.

Add Subheader option
3 participants
@daadu @felixwortmann @WieFel