add CameraPreview quarterTurns paramater #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexV525
requested changes
Sep 22, 2020
lib/src/widget/camera_picker.dart
Outdated
| @@ -50,6 +51,10 @@ class CameraPicker extends StatefulWidget { | |||
| : DefaultCameraPickerTextDelegate()); | |||
| } | |||
|
|
|||
| /// Quarter rotate turns. | |||
| /// 摄像机视图旋转次数 | |||
| @@ -81,6 +86,7 @@ class CameraPicker extends StatefulWidget { | |||
| bool isOnlyAllowRecording = false, | |||
| Duration maximumRecordingDuration = const Duration(seconds: 15), | |||
| ThemeData theme, | |||
| int cameraQuarterTurns = 0, | |||
lib/src/widget/camera_picker.dart
Outdated
| @@ -50,6 +51,10 @@ class CameraPicker extends StatefulWidget { | |||
| : DefaultCameraPickerTextDelegate()); | |||
| } | |||
|
|
|||
| /// Quarter rotate turns. | |||
| /// 摄像机视图旋转次数 | |||
| final int quarterTurns; | |||
lib/src/widget/camera_picker.dart
Outdated
| @@ -99,6 +105,7 @@ class CameraPicker extends StatefulWidget { | |||
| isAllowRecording: isAllowRecording, | |||
| isOnlyAllowRecording: isOnlyAllowRecording, | |||
| theme: theme, | |||
| quarterTurns: cameraQuarterTurns, | |||
lib/src/widget/camera_picker.dart
Outdated
| @@ -533,8 +540,7 @@ class CameraPickerState extends State<CameraPicker> { | |||
| children: <Widget>[ | |||
| const Spacer(), | |||
| // TODO(Alex): There's an issue tracking NPE of the camera plugin, so switching is temporary disabled . | |||
| if ((cameras?.length ?? 0) > 1) | |||
| switchCamerasButton, | |||
| if ((cameras?.length ?? 0) > 1) switchCamerasButton, | |||
AlexV525
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
增加了一个参数来控制相机视图旋转，用于在横屏下正常使用。