Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Use sensors to determine capture orientation #218

Merged
merged 9 commits into from
Oct 30, 2023
Merged

🚀 Use sensors to determine capture orientation #218

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ae236b3
🚀 Use sensors to determine capture orientation
AlexV525 Oct 26, 2023
f0cad10
⚡️ Respect config
AlexV525 Oct 26, 2023
8350577
🐛 ++
AlexV525 Oct 26, 2023
7c9849f
⚡️ Throttle harder
AlexV525 Oct 27, 2023
301e9f2
⚡️ Improve judgement
AlexV525 Oct 27, 2023
421b8b9
🐛 Fix iOS preview
AlexV525 Oct 27, 2023
c535156
Merge branch 'main' into feat/lock-capture-orientation
AlexV525 Oct 28, 2023
00ba5e0
🔖 4.1.0
AlexV525 Oct 28, 2023
e7c8c5a
⏪️ Revert iOS orientation
AlexV525 Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
⚡️ Throttle harder
  • Loading branch information
@AlexV525
AlexV525 committed Oct 27, 2023
commit 7c9849f4cc0183a4c1ddc4c6efa4eb182aedaeb2
18 changes: 13 additions & 5 deletions lib/src/states/camera_picker_state.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,9 @@ class CameraPickerState extends State<CameraPicker>
/// Subscribe to the accelerometer.
late final StreamSubscription<AccelerometerEvent> accelerometerSubscription;

/// The locked capture orientation of the current camera instance.
DeviceOrientation? lockedCaptureOrientation;

@override
void initState() {
super.initState();
Expand Down Expand Up @@ -332,6 +335,7 @@ class CameraPickerState extends State<CameraPicker>
lastExposurePoint.value = null;
currentExposureOffset.value = 0;
currentExposureSliderOffset.value = 0;
lockedCaptureOrientation = pickerConfig.lockCaptureOrientation;
});
// **IMPORTANT**: Push methods into a post frame callback, which ensures the
// controller has already unbind from widgets.
Expand Down Expand Up @@ -481,11 +485,14 @@ class CameraPickerState extends State<CameraPicker>
void handleAccelerometerEvent(AccelerometerEvent event) {
if (pickerConfig.lockCaptureOrientation != null ||
innerController == null ||
isControllerBusy) {
!controller.value.isInitialized ||
controller.value.isPreviewPaused ||
controller.value.isRecordingVideo ||
controller.value.isTakingPicture) {
return;
}
final x = event.x, y = event.y, z = event.z;
realDebugPrint('X:$x Y:$y Z:$z');
// realDebugPrint('X:$x Y:$y Z:$z');
final bool isLeft;
if (x > 0) {
isLeft = Platform.isAndroid ? true : false;
Expand All @@ -498,10 +505,10 @@ class CameraPickerState extends State<CameraPicker>
final DeviceOrientation newOrientation;
if (z < 9) {
if (y > 5) {
realDebugPrint('Accelerometer portrait');
// realDebugPrint('Accelerometer portrait');
newOrientation = DeviceOrientation.portraitUp;
} else if (y < 5) {
realDebugPrint('Accelerometer landscape');
// realDebugPrint('Accelerometer landscape');
newOrientation = isLeft
? DeviceOrientation.landscapeLeft
: DeviceOrientation.landscapeRight;
Expand All @@ -513,7 +520,8 @@ class CameraPickerState extends State<CameraPicker>
newOrientation = DeviceOrientation.portraitUp;
}
// Throttle.
if (controller.value.lockedCaptureOrientation != newOrientation) {
if (lockedCaptureOrientation != newOrientation) {
lockedCaptureOrientation = newOrientation;
controller.lockCaptureOrientation(newOrientation);
}
}
Expand Down
Loading