Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support set enableAudio attr #17

Merged
merged 4 commits into from
Oct 18, 2020
Merged

support set enableAudio attr #17

merged 4 commits into from
Oct 18, 2020

Conversation

siyukok
Copy link
Contributor

@siyukok siyukok commented Oct 18, 2020

pickFromCamera方法增加enableAudio可选参数，默认值为false，用于初始化CameraController，当enableAudio为false时，只使用拍照功能时，不会强制要求麦克风权限

@siyukok siyukok mentioned this pull request Oct 18, 2020
Closed
AlexV525
AlexV525 reviewed Oct 18, 2020
View reviewed changes
Copy link
Member

@AlexV525 AlexV525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

谢谢你的提交！有一个点可以修改下

lib/src/widget/camera_picker.dart Outdated Show resolved Hide resolved
lib/src/widget/camera_picker.dart Outdated Show resolved Hide resolved
@siyukok
Copy link
Contributor Author

siyukok commented Oct 18, 2020

@AlexV525 你好，重新提交了，辛苦帮忙review一下

AlexV525
AlexV525 approved these changes Oct 18, 2020
View reviewed changes
Copy link
Member

@AlexV525 AlexV525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 但是有一个格式修改麻烦回滚一下

lib/src/widget/camera_picker.dart Outdated Show resolved Hide resolved
@siyukok
Copy link
Contributor Author

siyukok commented Oct 18, 2020

LGTM 但是有一个格式修改麻烦回滚一下

已回滚

@AlexV525 AlexV525 merged commit 5603bc6 into fluttercandies:master Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexV525 AlexV525 AlexV525 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siyukok @AlexV525