Skip to content

Conversation

myxzlpltk
Copy link
Contributor

Now this package will support wasm 🥳🥳🥳

@myxzlpltk myxzlpltk changed the title Migrate js interop Migrate js interop fixes #297 May 23, 2024
@myxzlpltk
Copy link
Contributor Author

is there anything to improve? @fluttercandies

@MominRaza
Copy link
Contributor

@CaiJingLong Please review it

@hasanm08
Copy link

can you merge it and deploy on pub?
@MominRaza
@scascacha
@mono0926
@bes89

@MominRaza
Copy link
Contributor

@CaiJingLong @AlexV525 Please review this

@flawnn
Copy link

flawnn commented Jul 1, 2024

For the meantime, you can dependency override flutter_image_compress_web:

  flutter_image_compress_web:
    git:
      url: https://github.com/myxzlpltk/flutter_image_compress.git
      path: packages/flutter_image_compress_web

@alainjr10
Copy link

For the meantime, you can dependency override flutter_image_compress_web:

  flutter_image_compress_web:
    git:
      url: https://github.com/myxzlpltk/flutter_image_compress.git
      path: packages/flutter_image_compress_web

This works fine, on web only, but then if you need image compress on other platforms in addition to running on web, it doesn't get the job done, because the main flutter image compress package still depends on flutter image compress web from pub.dev, which isn't wasm compatible yet.
I managed to fork the repo and made it web compatible, and removing the hosted dependencies as well, and having all of the dependencies local to the package. Here's the url
https://github.com/alainjr10/flutter_image_compress.git

@CaiJingLong CaiJingLong merged commit 7f05c9b into fluttercandies:main Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants