Remove Rosetta instructions from macOS page #7139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #7137
timsneath
requested review from
sfshaza2,
khanhnwin,
domesticmouse and
johnpryan
as code owners
|
We still need Rosetta installed on the host for several binaries as explained in #7119. |
|
Actually reopening, I didn't see the second non-Rosetta part which is a good change. |
jmagman
requested changes
May 16, 2022
|
Ah. Thanks. I’ll tweak the Rosetta part to explain and resubmit.
…On Sun, May 15, 2022 at 9:32 PM Jenn Magder ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Need to keep the Rosetta instructions.
—
Reply to this email directly, view it on GitHub
<#7139 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARWL6ZKTDSU26PLEDIPDATVKHFUFANCNFSM5WAEKQFQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Add back Rosetta note, with link to a note about where there are existing dependencies.
|
Have a look and see if this is OK with you -- I added back the Rosetta sidebar with an embedded link to your comment on the older bug so that it's clear to those (like myself) who might have thought that Rosetta was no longer needed as of Flutter 3. |
domesticmouse
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes Rosetta instructions now that we have M1 support. Also clarifies that you can build macOS apps with a macOS developer workstation.
Issues fixed by this PR (if any):
#7137
Presubmit checklist