Skip to content

Updated the integration_test page #5693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 27, 2021
Merged

Updated the integration_test page #5693

merged 7 commits into from
Apr 27, 2021

Conversation

sfshaza2
Copy link
Contributor

@sfshaza2 sfshaza2 commented Apr 26, 2021

Made the following changes:

  • Changed the URLs to use the macros defined in _config.yml
  • Changed the headers to use sentence case, as per our style guidelines
  • Changed the link to the integration_test package to use the link in the Flutter SDK GitHub repo, rather than the pub.dev link.
  • Added a note about the integration_test package moving to the Flutter SDK (and out of pub.dev) as of Flutter 2.
  • Also added a note that this requires a change to the app's pubspec file.
  • Finally, shortened the line lengths so that the raw file is easier for me to read.

@sfshaza2 sfshaza2 requested a review from johnpryan April 26, 2021 23:46
@google-cla google-cla bot added the cla: yes Contributor has signed the Contributor License Agreement label Apr 26, 2021
Copy link
Contributor

@johnpryan johnpryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding my changes from #5700 to this PR, otherwise looks good.

sfshaza2 and others added 5 commits April 27, 2021 12:44
Co-authored-by: John Ryan <ryjohn@google.com>
Co-authored-by: John Ryan <ryjohn@google.com>
Co-authored-by: John Ryan <ryjohn@google.com>
Co-authored-by: John Ryan <ryjohn@google.com>
Co-authored-by: John Ryan <ryjohn@google.com>
@sfshaza2 sfshaza2 merged commit 14b540a into master Apr 27, 2021
@sfshaza2 sfshaza2 deleted the test branch April 27, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Contributor has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants