Skip to content

Update deep link docs due to the flutter_deeplinking_enabled flag default value change. #11461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 4, 2024
Merged

Update deep link docs due to the flutter_deeplinking_enabled flag default value change. #11461

merged 5 commits into from
Dec 4, 2024

Conversation

hannah-hyj
Copy link
Member

@hannah-hyj hannah-hyj commented Dec 3, 2024 •
edited
Loading

The deep link flag default value is changed in flutter/engine#52350, and the PR is included Flutter 3.27 stable release.

The Deep link docs should be updated to reflect the changes:

  1. If you are using flutter deep link handlers, you don't need to manually set the flutter_deeplinking_enabled flag to true anymore.
  2. If you use third-party plug-ins to handle deep links, you need to manually set the flutter_deeplinking_enabled flag to false

More context: Design doc

_Issues fixed by this PR (if any): #10984

_PRs or commits this PR depends on (if any): flutter/engine#52350

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

@hannah-hyj hannah-hyj requested review from sfshaza2, parlough and a team as code owners December 3, 2024 18:50
@hannah-hyj hannah-hyj requested a review from chunhtai December 3, 2024 18:50
@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Dec 3, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 503f891):

https://flutter-docs-prod--pr11461-deep-link-flag-change-de4vci3h.web.app

chunhtai
chunhtai approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sfshaza2
sfshaza2 reviewed Dec 3, 2024
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @hannah-hyj, for this PR! I've done some word smithing and have one question before it can land.

@sfshaza2 sfshaza2 added the review.await-update Awaiting Updates after Edits label Dec 3, 2024
@hannah-hyj @sfshaza2
Update src/content/cookbook/navigation/set-up-universal-links.md
503f891 
Update src/content/ui/navigation/deep-linking.md

Update src/content/cookbook/navigation/set-up-universal-links.md

Update src/content/cookbook/navigation/set-up-app-links.md

Update src/content/cookbook/navigation/set-up-app-links.md

Update src/content/cookbook/navigation/set-up-app-links.md

Co-Authored-By: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>
@hannah-hyj hannah-hyj force-pushed the deep-link-flag-change branch from 614a0c7 to 503f891 Compare December 3, 2024 23:17
sfshaza2
sfshaza2 approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfshaza2 sfshaza2 removed the review.await-update Awaiting Updates after Edits label Dec 4, 2024
@sfshaza2 sfshaza2 merged commit 204f659 into main Dec 4, 2024
9 checks passed
@sfshaza2 sfshaza2 deleted the deep-link-flag-change branch December 4, 2024 18:36
@hannah-hyj hannah-hyj mentioned this pull request Dec 26, 2024
Merged
hannah-hyj added a commit that referenced this pull request Jan 6, 2025
@hannah-hyj @parlough
Update deep link guide with a note for version earlier than 3.27 (#11552
06d8df4 
)

Follow up on #11526.

This PR added a note for flutter version earlier than 3.27, you need to
manually add code to opt-in to flutter deep link.

Related PR: #11461.

---------

Co-authored-by: Parker Lougheed <parlough@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfshaza2 sfshaza2 sfshaza2 approved these changes

@chunhtai chunhtai chunhtai approved these changes

@parlough parlough Awaiting requested review from parlough parlough is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hannah-hyj @flutter-website-bot @sfshaza2 @chunhtai