Null safety for Shimmer effect #10071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of type 'RenderBox' in type cast
agavrel
requested review from
sfshaza2,
atsansone,
parlough,
domesticmouse and
MaryaBelanger
as code owners
domesticmouse
requested changes
Jan 21, 2024
There was a problem hiding this comment.
Please see https://github.com/dart-lang/site-shared/blob/main/doc/code-excerpts.md on how to update the code excerpts. Thanks!
|
/gcbrun |
|
Visit the preview URL for this PR (updated for commit 32026f0): |
Co-authored-by: Navaron Bracke <brackenavaron@gmail.com>
|
/gcbrun |
domesticmouse
approved these changes
Jan 31, 2024
atsansone
pushed a commit
to atsansone/website
that referenced
this pull request
Feb 15, 2024
atsansone
pushed a commit
to atsansone/website
that referenced
this pull request
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what this PR is changing or adding, and why:
check that
context.findRenderObject() != nullIssues fixed by this PR (if any):
prevent "type 'Null' is not a subtype of type 'RenderBox' in type cast" segmentation fault
Presubmit checklist