Skip to content

Update the DevTools hash to the latest. #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Update the DevTools hash to the latest. #461

wants to merge 2 commits into from

Conversation

kenzieschmoll
Copy link
Member

No description provided.

@kenzieschmoll kenzieschmoll mentioned this pull request Jun 24, 2025
Open
9 tasks
justinmc
justinmc approved these changes Jun 24, 2025
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 . Thanks for opening this PR! Hopefully it fixes flutter/flutter#170544.

@kenzieschmoll
Copy link
Member Author

@justinmc Looks like the checks are failing on the patrol customer tests, which I saw on flutter/flutter#170544 too. Have you already reached out to folks from leancode to address these tests? Should I send a separate PR to disable them while they are broken?

Processing ./registry/patrol.test...
Created temporary directory: /var/folders/y6/nj790rtn62lfktb1sh__79hc0000gn/T/flutter_customer_testing.patrol.EpNspz
>> git clone https://github.com/leancodepl/patrol.git tests
| Cloning into 'tests'...
>> git -C tests checkout b8bcebf96ff13e37fdc5474804d68e2352e472a4
| HEAD is now at b8bcebf9 chore: Add note to readme to explain branch purpose
Updating code in /var/folders/y6/nj790rtn62lfktb1sh__79hc0000gn/T/flutter_customer_testing.patrol.EpNspz/tests/packages/patrol_cli...
>> flutter packages get
| Resolving dependencies...
| Because leancode_lint >=14.3.0 <14.4.0 depends on analyzer ^6.7.0 and analyzer >=6.6.0 <6.9.0 depends on macros >=0.1.2-main.3 <0.1.3, leancode_lint >=14.3.0 <14.4.0 requires macros >=0.1.2-main.3 <0.1.3 or analyzer ^6.9.0.
| Because macros >=0.1.2-main.4 <0.1.3-main.0 depends on _macros 0.3.2 from sdk and macros >=0.1.2-main.2 <0.1.2-main.4 depends on _macros 0.3.1 from sdk, macros >=0.1.2-main.2 <0.1.3-main.0 requires _macros 0.3.1 or 0.3.2 from sdk.
| Thus, leancode_lint >=14.3.0 <14.4.0 requires analyzer ^6.9.0 or _macros 0.3.1 or 0.3.2 from sdk.
| And because leancode_lint >=14.4.0 <15.1.0 depends on analyzer ^6.11.0, leancode_lint >=14.3.0 <15.1.0 requires analyzer ^6.9.0 or _macros 0.3.1 or 0.3.2 from sdk.
| And because analyzer >=6.9.0 <7.3.0 depends on macros >=0.1.3-main.0 <0.1.4 which depends on _macros 0.3.3 from sdk, leancode_lint >=14.3.0 <15.1.0 requires _macros 0.3.1 or 0.3.2 or 0.3.3 from sdk.
| So, because _macros from sdk doesn't exist (could not find package _macros in the Dart SDK) and patrol_cli depends on leancode_lint ^14.3.0, version solving failed.
|
|
| You can try the following suggestion to make the pubspec resolve:
| * Try upgrading your constraint on leancode_lint: flutter pub add dev:leancode_lint:^17.0.0
| Failed to update packages.
ERROR: Could not run "flutter pub get" in packages/patrol_cli, which was specified as an update directory.
Deleting temporary directory...
Contacts: piotr.denert@leancode.pl, piotr.maszota@leancode.pl, mateusz.wojtczak@leancode.pl, julia.borkowska@leancode.pl

@justinmc
Copy link
Contributor

@kenzieschmoll I have not, thanks for noticing that. I'm about to be OOO for a week so no rush on my side. Maybe I can check in when I'm back and then disable them if they're still broken?

@justinmc justinmc mentioned this pull request Jul 11, 2025
Merged
auto-submit bot pushed a commit that referenced this pull request Jul 14, 2025
@justinmc
Disabled Patrol (and devtools) tests due to failure (#462)
7afa986 
The Patrol tests are failing due to a dependency error. I'm trying to bump the customer tests but can't because of this. See #461, which shows the failing tests.

We definitely should re-enable these test once they're fixed! I'm just trying to get things moving along.

From [this run](https://github.com/flutter/tests/actions/runs/15858365759/job/45589357091) I see:

```
>> flutter packages get
| Resolving dependencies...
| Because leancode_lint >=14.3.0 <14.4.0 depends on analyzer ^6.7.0 and analyzer >=6.6.0 <6.9.0 depends on macros >=0.1.2-main.3 <0.1.3, leancode_lint >=14.3.0 <14.4.0 requires macros >=0.1.2-main.3 <0.1.3 or analyzer ^6.9.0.
| Because macros >=0.1.2-main.4 <0.1.3-main.0 depends on _macros 0.3.2 from sdk and macros >=0.1.2-main.2 <0.1.2-main.4 depends on _macros 0.3.1 from sdk, macros >=0.1.2-main.2 <0.1.3-main.0 requires _macros 0.3.1 or 0.3.2 from sdk.
| Thus, leancode_lint >=14.3.0 <14.4.0 requires analyzer ^6.9.0 or _macros 0.3.1 or 0.3.2 from sdk.
| And because leancode_lint >=14.4.0 <15.1.0 depends on analyzer ^6.11.0, leancode_lint >=14.3.0 <15.1.0 requires analyzer ^6.9.0 or _macros 0.3.1 or 0.3.2 from sdk.
| And because analyzer >=6.9.0 <7.3.0 depends on macros >=0.1.3-main.0 <0.1.4 which depends on _macros 0.3.3 from sdk, leancode_lint >=14.3.0 <15.1.0 requires _macros 0.3.1 or 0.3.2 or 0.3.3 from sdk.
| So, because _macros from sdk doesn't exist (could not find package _macros in the Dart SDK) and patrol_cli depends on leancode_lint ^14.3.0, version solving failed.
|
|
| You can try the following suggestion to make the pubspec resolve:
| * Try upgrading your constraint on leancode_lint: flutter pub add dev:leancode_lint:^17.0.0
| Failed to update packages.
ERROR: Could not run "flutter pub get" in packages/patrol_cli, which was specified as an update directory.
Deleting temporary directory...
Contacts: piotr.denert@leancode.pl, piotr.maszota@leancode.pl, mateusz.wojtczak@leancode.pl, julia.borkowska@leancode.pl
```
@justinmc
Copy link
Contributor

@kenzieschmoll Now that #462 is merged and devtools tests are disabled, I guess I no longer have a dependency on this PR for my work. Maybe once you all have fixed the devtools tests then this PR can be used to update to that new SHA.

@kenzieschmoll
Copy link
Member Author

Closing this. @elliette will address flutter/flutter#172037 to re-enable the DevTools customer tests.

@justinmc
Copy link
Contributor

Sounds good, thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmc justinmc justinmc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenzieschmoll @justinmc