fixed crash if you back out of 2 double engine activities #763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
xster
approved these changes
Mar 9, 2021
| @@ -20,6 +20,10 @@ class DoubleFlutterActivity : FragmentActivity(), EngineBindingsDelegate { | |||
| EngineBindings(activity = this, delegate = this, entrypoint = "bottomMain") | |||
| } | |||
| private val numberOfFlutters = 2 | |||
| private var engineCountStart = 0 | |||
| private companion object { | |||
| var engineCount = 0 | |||
There was a problem hiding this comment.
totalEngineCount for readability? Since you have a lot of engine* names in this file.
There was a problem hiding this comment.
IMO that is a bit misleading because that would suggest it was the number of engines alive, not the number of engines ever made.
There was a problem hiding this comment.
How about engineCounter?
There was a problem hiding this comment.
you're right. Let's leave it as is.
| @@ -20,6 +20,10 @@ class DoubleFlutterActivity : FragmentActivity(), EngineBindingsDelegate { | |||
| EngineBindings(activity = this, delegate = this, entrypoint = "bottomMain") | |||
| } | |||
| private val numberOfFlutters = 2 | |||
| private var engineCountStart = 0 | |||
There was a problem hiding this comment.
Could this be private val engineCountStart = engineCount? We need to make sure the value never changes through future refactors so the onDestroy start number is right and not leak.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #762