Improve color display in M3 Demo #2438
Conversation
Change threshold to show wider schematic on wide screens. SchemePreview displays colors in a similar fashion to MTB and Design Kit aligning with other design materials.
dart fix
fix failing lint tests
remove deprecated usages
Added comments with note of API change coming on 3.26+
|
Please |
|
@Piinks is there somewhere I can advocate for deprecation of a feature and the addition of its replacement to be in staggered releases? |
| @@ -47,7 +47,8 @@ declare -ar PROJECT_NAMES=( | |||
| "infinite_list" | |||
| "ios_app_clip" | |||
| "isolate_example" | |||
| "material_3_demo" | |||
| # TODO @ewindmill -- Color.red is deprecated and should be Color.r (same for green and blue) | |||
| # "material_3_demo" | |||
There was a problem hiding this comment.
@jwill FYI, this is how to turn CI off for a specific sample in a specific environment.
We do this when an API is being deprecated in an upcoming version, and theres no way to make CI for Stable and beta channels happy at the same time. Ahead of every release, I update the sample code to reflect what will be in the new stable, and then add all the samples back to CI for the beta and master flutter channels.
There was a problem hiding this comment.
LGTM! Thanks a lot for improving the color layouts! For ColorScheme, we also support primaryFixed, primaryFixedDim, onPrimaryFixed, onPrimaryVarient and similar color roles for secondary, and tertiary groups, do we also want to show them like here? I don't think any widgets are using them though, so either way is fine to me.
Removed commented code.
Before:
After:
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-devrel channel on Discord.