Skip to content

[Compass App] Cleanup and extra tests #2437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 16, 2024

Conversation

miquelbeltran
Copy link
Member

@miquelbeltran miquelbeltran commented Sep 12, 2024

Some changes to make the project ready to merge to main

  • Fix formatting.
  • Add project to the stable channel CI (potentially could be added for beta and master)
    • CI only runs when targeting main, so I run the command locally and it worked.
  • Add unit tests for the ApiClient and AuthApiClient which had no test coverage outside of integration tests.
  • Resolved some TODOs I left before.

Pre-launch Checklist

  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I read the Contributors Guide.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

@miquelbeltran miquelbeltran marked this pull request as ready for review September 13, 2024 13:55
@miquelbeltran miquelbeltran merged commit 799ce7f into compass-app Sep 16, 2024
1 check passed
@miquelbeltran miquelbeltran deleted the mb-compass-app-cleanup branch September 16, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants