Skip to content

[Compass App] User name and profile picture #2435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 12, 2024
Merged

Conversation

miquelbeltran
Copy link
Member

This PR completes the home screen, adding the username and the profile picture.

Screenshot from 2024-09-11 14-52-32
Screenshot from 2024-09-11 14-52-23

This feature follows the basic structure:

  • Added repository, both local and remote.
  • Added API call + API model.
  • Added Domain model (reduced version only containing name and profile picture).
  • Modified the ViewModel to obtain the user and expose it to the Widget.
  • Updated Widget to display the username and profile picture.
  • Added /user endpoint to server project.
  • Updated widget tests, as well as integration tests.

The Compass App is basically completed with it. Maybe the next step is to merge it to the main branch? And then we can do a full review, remove TODOs and setup CI jobs.

Pre-launch Checklist

  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I read the Contributors Guide.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

Copy link
Contributor

@ericwindmill ericwindmill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straight forward. LGTM.

@miquelbeltran miquelbeltran merged commit b00ce6c into compass-app Sep 12, 2024
1 check passed
@miquelbeltran miquelbeltran deleted the mb-user-profile branch September 12, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants