[Compass App] Refactor model #2431
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
compass_model
subproject and moves each data model class to the respectiveapp
orserver
project.Although this leads to code duplication, this is a more realistic implementation where clients and servers have their own respective data model class implementations.
The model classes for the server are located in
server/lib/model
.Model classes for the app are located in two places:
app/lib/data/services/api/model
.app/lib/domain/model
.In general, models located under the domain are used across the app, while the API-only models are only used for interacting with the API client.
Tests have been updated.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-devrel channel on Discord.