Skip to content

Cleaning up Veggie Seasons #2416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

domesticmouse
Copy link
Contributor

Pre-launch Checklist

  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I read the Contributors Guide.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

@domesticmouse domesticmouse force-pushed the veggieseasons-requested-changes branch from c054dd3 to 3f3f50d Compare August 30, 2024 03:32
@domesticmouse domesticmouse force-pushed the veggieseasons-requested-changes branch from 3f3f50d to f404816 Compare August 30, 2024 03:34
@sethladd
Copy link
Contributor

tested locally, thank you!

Consider landing this now, I don't think we need to wait for the CI to get updated.

@ericwindmill
Copy link
Contributor

tested locally, thank you!

Consider landing this now, I don't think we need to wait for the CI to get updated.

@sethladd If you want to land now, can you remove it from CI by commenting it out in the three ci files? (e.g. tool/flutter_ci_script_beta.sh, etc)

@ericwindmill ericwindmill merged commit bee21b5 into flutter:main Aug 30, 2024
4 of 14 checks passed
@ericwindmill
Copy link
Contributor

I'm following up with a PR for the CI failures.

@sethladd
Copy link
Contributor

thanks for the help!

@domesticmouse
Copy link
Contributor Author

tested locally, thank you!

Consider landing this now, I don't think we need to wait for the CI to get updated.

@sethladd If you want to land now, can you remove it from CI by commenting it out in the three ci files? (e.g. tool/flutter_ci_script_beta.sh, etc)

Veggie Seasons should not be removed from CI.

@domesticmouse domesticmouse deleted the veggieseasons-requested-changes branch August 30, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants