Skip to content

Compass App: Integration tests and image error handling #2389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

miquelbeltran
Copy link
Member

@miquelbeltran miquelbeltran commented Aug 19, 2024

This PR goes on top of PR #2385 adding integration test using the integration_test package.

Adds integration_test folder with two test suits:

  • Local test: Uses the local dependency config that pulls data from the assets folder and has no login logic.
  • Remote test: Starts the dart server in the background and uses the remote dependency config, pulls data from the server and performs login/logout.

To run the tests:

flutter test integration_test/app_server_data_test.dart

or

flutter test integration_test/app_local_data_test.dart

Running both at once with flutter test integration_test will likely fail, seems this issue is related: flutter/flutter#101031

Also, this PR fixes exceptions being thrown by the network image library, now instead they get logged using the app Logger.

Pre-launch Checklist

  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I read the Contributors Guide.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

@miquelbeltran miquelbeltran marked this pull request as ready for review August 19, 2024 13:03
Base automatically changed from mb-compass-app-auth to compass-app August 20, 2024 11:45
Copy link
Contributor

@ericwindmill ericwindmill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miquelbeltran miquelbeltran merged commit 56bf31f into compass-app Aug 21, 2024
1 check passed
@miquelbeltran miquelbeltran deleted the mb-compass-e2e branch August 21, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants